-
Notifications
You must be signed in to change notification settings - Fork 64
feat: cropped images #1940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: cropped images #1940
Conversation
|
Hi @chittolinag! Since you added some support for stretch and fillRect maybe you could take a look to this PR |
|
I'll proceed with my review based on my knowledge of the ECMA-376 specification and code analysis: Status: PASS This PR implements image cropping using the What was reviewedThe PR adds support for DOCX image cropping by reading Handler implementation (encode-image-node-helpers.js:75-108)The
Validation logicThe function correctly:
Output formatThe generated
Test coverageTests verify:
ReferenceFor details on No spec violations detected. The implementation correctly interprets ECMA-376 Part 1 §20.1.8.55 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 611b9f621d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Added cropped images support. Renders cropped portion of image in Superdoc and preserves it on export.