-
Notifications
You must be signed in to change notification settings - Fork 64
fix: issue updating paragraph properties (SD-1778) #1944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue updating paragraph properties (SD-1778) #1944
Conversation
luccas-harbour
commented
Feb 4, 2026
- Fixes an issue updating run properties inside paragraph properties that would prevent marks from being applied properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6be23018ec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
packages/super-editor/src/extensions/run/calculateInlineRunPropertiesPlugin.js
Outdated
Show resolved
Hide resolved
|
@luccas-harbour let's add an interactions story if possible pls! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just double check Codex comment and Nick's comment about interactions story, feel free to merge after that
packages/super-editor/src/extensions/run/calculateInlineRunPropertiesPlugin.js
Outdated
Show resolved
Hide resolved
468fd6e to
cc2f5bc
Compare
cc2f5bc to
674b416
Compare
|
@harbournick I added the story. Please have a look at it to make sure it's good and then you can merge this one. |
…-schema-on-select-all
|
🎉 This PR is included in superdoc v1.11.0-next.20 The release is available on GitHub release |