feat: (esign) introduce viewOptions for document layout and deprecate layoutMode and layoutMargins#1957
Conversation
… layoutMode and layoutMargins - Added `viewOptions` to control document layout with options for 'web' and 'print'. - Deprecated `layoutMode` and `layoutMargins`, recommending CSS for margin control. - Updated documentation and examples to reflect the new configuration.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22204e04c8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
looking good! make sure to test it locally and make sure it works with the new options
after addressing relevant comments feel free to merge
- Improved the logic for setting `viewOptions` to ensure it falls back to `layoutMode` when `viewOptions` is an empty object. - Updated the documentation to clarify the recommended usage of `viewOptions` for SuperDoc versions greater than 1.6.x. - Added a test case to verify the fallback behavior for layout options.
harbournick
deleted the
andrii/sd-1789-esign-component-not-passing-web-view-parameter
branch
|
🎉 This PR is included in esign v2.1.0-next.4 The release is available on GitHub release |
|
🎉 This PR is included in superdoc v1.11.0-next.19 The release is available on GitHub release |
3 participants
viewOptionsto control document layout with options for 'web' and 'print'.layoutModeandlayoutMargins, recommending CSS for margin control.