Skip to content

PR example #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suranc wants to merge 8 commits into
base: master
Choose a base branch
from
Open

PR example #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4c40721
Add fullnameOverride based on infra def and service name
suranc Aug 2, 2022
d6cfc7b
Correct filename for rename valuess
suranc Aug 2, 2022
cfdc973
Fix release name
suranc Aug 2, 2022
8cce38a
Add nameOverride
suranc Aug 2, 2022
2c6546d
Switch to use nameOverride on instance label
suranc Aug 2, 2022
29f7546
Add instancenameOverride
suranc Aug 2, 2022
bbbcae3
Add range example
suranc Aug 4, 2022
37dea87
Fix names
suranc Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm-chart/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Selector labels
*/}}
{{- define "spring-forward.selectorLabels" -}}
app.kubernetes.io/name: {{ include "spring-forward.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/instance: {{ .Values.instancenameOverride }}
{{- end }}

{{/*
Expand Down
4 changes: 4 additions & 0 deletions helm-chart/templates/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
test:
{{- range $key, $secret := .Values.secret }}
{{- printf "%s: %s" $key $secret | nindent 2 }}
{{- end }}
3 changes: 3 additions & 0 deletions helm-chart/values-name-rename-Spring Forward.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
instancenameOverride: "release-rename"
nameOverride: "spring-forward"
fullnameOverride: "release-rename-spring-forward"
4 changes: 4 additions & 0 deletions helm-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
# This is a YAML-formatted file.
# Declare variables to be passed into your templates.

secret:
test1: value
test2: value

replicaCount: 1

image:
Expand Down