Fix datetime precision regression from Timex.shift/2
#60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Elixir 1.14+,
Timex.shift/2upgrades datetime precision to microseconds due to changes inDateTime.add/4.This
caused date_and_offset_to_datetime/3to return datetimes like~U[2023-01-01 10:00:00.000000Z]instead of~U[2023-01-01 10:00:00Z], breaking Ecto validations and equality checks.Fix: truncate to
:secondprecision after shift since input is always~T[00:00:00](second precision).Also updates all dependencies to latest compatible versions.
Is it the same fix as the fork?
No. The fork preserves the original precision dynamically:
My fix hardcodes :second truncation:
Ref: bitwalker/timex#731