3d camera feature

[Mosch0512]

added 3d camera
its not perfect i had to limit the pitch when camera is close to ground due to rendering issues i could not solve

closes #253

[gemini-code-assist]

Summary of Changes

Hello @Mosch0512, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new 3D camera feature, enabling players to control their viewpoint with greater flexibility. The system allows for dynamic zooming, horizontal rotation, and vertical pitching around the character, enhancing the overall immersion and perspective. To support this new camera, several rendering components have been updated to correctly display terrain, effects, and pointers, ensuring visual consistency and functionality across different camera settings.

Highlights

• New 3D Camera System: Introduces a comprehensive 3D camera with zoom, horizontal rotation, and vertical pitch controls.
• Dynamic Camera Controls: Allows players to zoom in/out using the mouse wheel and rotate/pitch the camera using the middle mouse button. The camera can be toggled on/off with the F9 key.
• Rendering Adjustments for 3D View: Implements dynamic adjustments to the rendering frustum, object visibility, and pointer scaling to ensure proper display across various zoom levels and angles.
• Camera State Management: Saves and restores the original camera state to seamlessly switch between default and 3D camera modes.
• Bug Fix: Corrects a minor input handling bug in Winmain.cpp where the middle mouse button release was incorrectly setting MouseRButton instead of MouseMButton.
• Known Limitation: The camera's pitch is limited when close to the ground due to unresolved rendering issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new CCustomCamera3D system, enabling players to control camera zoom, horizontal rotation, and vertical pitch using the mouse wheel and middle mouse button, toggled by the F9 key. The new camera system dynamically adjusts rendering parameters such as frustum culling, object visibility range, pointer scaling, and terrain rendering bounds based on the camera's zoom level to prevent visual artifacts when zoomed out. It also includes a fix for an incorrect mouse button state in Winmain.cpp and ensures proper camera state restoration in ZzzOpenglUtil.cpp. Review comments suggest replacing while loops for angle normalization with fmodf, using a dedicated boolean flag instead of (0,0,0) to track the initial camera offset, removing an unused m_bF9KeyPressed member, and replacing several 'magic numbers' with named constants for improved readability and maintainability, along with removing a debug logging block.