Conversation
|
@JAicewizard sadly this doesn't quite do what you'd expect of it: (see bottom of screen) https://user-images.githubusercontent.com/41264528/199676602-47b29484-2d8e-47db-9b6e-744265ae001b.MOV |
36506bd to
aa89844
Compare
|
Ive never seen git make such a mess with just a single commit, I checked everything hope nothing wrong changed. Just a simple rebase |
|
Github often takes a minute to correctly display the commit list after a rebase, looks fine now. |
This fixes lists not scrolling under the safearea, and works around issues with CustomScrollView
|
The solution for safearea+CustomScrollView is a giant hack, but it does work. Unlike Listview it doesnt automatically add padding around its children, so we have to manually add padding around the entire view for left/right and padding at the bottom/top inside the list itself. Maybe this could be hidden away in a custom widget that wraps CustomScrollView with propper padding? Would make things cleaner. To actually make sure the children don't also add a safearea we will have to make changes some changes again ant it will only make it uglier. |
|
@DeD1rk review |
Closes #169.