fix: apply minItems/minLength from @NotEmpty/@NotBlank regardless of requiredMode #5033
+37
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2026 16:46
…generates minItems:1
…requiredMode When @notempty or @notblank annotations were combined with @Schema(requiredMode = REQUIRED) or @Schema(requiredMode = NOT_REQUIRED), the minItems and minLength constraints were not being generated in the OpenAPI schema. This was caused by the applyNotNullAnnotations flag incorrectly gating the entire @NotEmpty/@notblank processing block. The flag should only control whether the field is added to the required list, not whether minItems/minLength are set. The fix separates these concerns: - minItems/minLength are always applied when @NotEmpty/@notblank are present - updateRequiredItem() is only called when applyNotNullAnnotations is true Fixes regression introduced between 2.2.40 and 2.2.41.
burneyy
changed the title
2 tasks
daniel-kmiecik
approved these changes
Jan 8, 2026
Collaborator
|
@burneyy thanks for your contribution. Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
When
@NotEmptyor@NotBlankannotations are combined with@Schema(requiredMode = REQUIRED)or@Schema(requiredMode = NOT_REQUIRED), theminItemsandminLengthconstraints are not being generated in the OpenAPI schema.Root cause: The
applyNotNullAnnotationsflag was incorrectly gating the entire@NotEmpty/@NotBlankprocessing block. This flag istrueonly whenrequiredMode == AUTO, so when users explicitly setrequiredModetoREQUIREDorNOT_REQUIRED, the validation constraints were completely skipped.The fix: Separates the concerns:
minItems/minLengthare always applied when@NotEmpty/@NotBlankare presentupdateRequiredItem()is only called whenapplyNotNullAnnotationsis trueThis is a regression introduced between 2.2.40 and 2.2.41.
Fixes: #5032
Type of Change
Checklist
Screenshots / Additional Context
See #5032