[WebAssembly] Add no-op MutexWASI.h implementation#29459
[WebAssembly] Add no-op MutexWASI.h implementation#29459compnerd merged 2 commits intoswiftlang:masterfrom
Conversation
|
@jrose-apple @stephentyrone @tbkka would any of you be available for a review please? Otherwise should I request it from anyone else? Thanks! |
gribozavr
left a comment
gribozavr
left a comment
There was a problem hiding this comment.
LGTM with a small change to the comment.
include/swift/Runtime/MutexWASI.h
Outdated
| // | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Stub implementation of Mutex, ConditionVariable, Read/Write lock, and Scoped |
There was a problem hiding this comment.
s/stub/no-op/
I wouldn't say "no concrete implementation is provided" because it is a concrete implementation, it just does not perform locking.
"No-op implementation of locks for the WebAssembly System Interface. The implementation does not need to perform locking, because as of <insert WebAssembly spec version, or today's date> WebAssembly does not support threads."
|
@swift-ci Please smoke test |
|
@gribozavr could you trigger a CI run here? Thank you! |
|
@swift-ci Please smoke test |
|
@gribozavr I don't think |
|
@swift-ci please smoke test Linux platform |
|
@MaxDesiatov in the future, please keep fixups to the change in a single commit in the future. |
3 participants
Since WebAssembly doesn't support threading, no locking is done in runtime. This PR adds a no-op implementation in
MutexWASI.hto improve compatibility with WASI.This is a part of SR-9307 and #24684.
(cc @kateinoigakukun @zhuowei)