Skip to content

[WASM] [BuildScript] Initial Support for building WASI toolchain#29465

Closed
kateinoigakukun wants to merge 1 commit intoswiftlang:mainfrom
kateinoigakukun:katei/swasm/build-script
Closed

[WASM] [BuildScript] Initial Support for building WASI toolchain#29465
kateinoigakukun wants to merge 1 commit intoswiftlang:mainfrom
kateinoigakukun:katei/swasm/build-script

Conversation

@kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Jan 27, 2020 •
edited
Loading

This PR adds WASI toolchain variant to port our WebAssembly support, step by step.

This is a part of SR-9307 and #24684.

compnerd
compnerd requested changes Jan 27, 2020
View reviewed changes
@kateinoigakukun kateinoigakukun force-pushed the katei/swasm/build-script branch 2 times, most recently from fb2d12b to cc75c28 Compare January 27, 2020 06:41
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jan 28, 2020

Does this work conflict your recent work @compnerd ?

@compnerd
Copy link
Member

compnerd commented Jan 29, 2020

@kateinoigakukun yes, it does. Also, please don't create large stacks of commits in a single PR, it makes it more difficult to review.

@kateinoigakukun kateinoigakukun force-pushed the katei/swasm/build-script branch from 40e6fd8 to d348a40 Compare January 29, 2020 05:48
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jan 29, 2020

@compnerd OK, I fixed up them in 1 commit

@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented Feb 12, 2020

Hi @compnerd, would you be able to have another look at this PR? Thank you and much appreciated!

@MaxDesiatov MaxDesiatov mentioned this pull request Feb 13, 2020
Closed
@MaxDesiatov
Copy link
Contributor

MaxDesiatov commented Feb 16, 2020

Hi @gribozavr @CodaFi would you be able to help with reviewing this PR? Or could you redirect to someone else more appropriate? Thank you 🙏

@MaxDesiatov MaxDesiatov mentioned this pull request Feb 17, 2020
Closed
78 tasks
@gribozavr
Copy link
Contributor

gribozavr commented Feb 17, 2020

The changes look good to me, but since I haven't touched the build system in a couple of years, I don't think my review in this area counts much. @compnerd ?

compnerd
compnerd reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s some more adjustments still needed I think.

@kateinoigakukun kateinoigakukun force-pushed the katei/swasm/build-script branch 3 times, most recently from 09e952d to 047ab39 Compare February 18, 2020 07:21
@kateinoigakukun kateinoigakukun force-pushed the katei/swasm/build-script branch from 047ab39 to af049c8 Compare March 13, 2020 11:55
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Mar 13, 2020

@compnerd I minimized build-script related changes and changed to pass some options through extra-cmake-options directly temporarily to avoid conflicts.

@MaxDesiatov MaxDesiatov mentioned this pull request May 9, 2020
Merged
patcheng
patcheng reviewed May 12, 2020
View reviewed changes
utils/build-script-impl
skip-test-osx "" "set to skip testing Swift stdlibs for OS X"
skip-test-tvos-host "" "set to skip testing the host parts of the tvOS toolchain"
skip-test-tvos-simulator "" "set to skip testing Swift stdlibs for tvOS simulators (i.e. test devices only)"
skip-test-wasi "" "set to skip testing Swift stdlibs for WebAssembly/WASI"
Copy link

@patcheng patcheng May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be a matching skip-build-wasi somewhere as well?

@MaxDesiatov MaxDesiatov changed the base branch from master to main September 24, 2020 08:53
@kateinoigakukun
Copy link
Member Author

kateinoigakukun commented Jun 10, 2023

We've already merged a lot of parts in this PR step by step, so close now

@kateinoigakukun kateinoigakukun deleted the katei/swasm/build-script branch June 10, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@compnerd compnerd compnerd requested changes

@MaxDesiatov MaxDesiatov MaxDesiatov left review comments

@karwa karwa karwa left review comments

+1 more reviewer

@patcheng patcheng patcheng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kateinoigakukun @compnerd @MaxDesiatov @gribozavr @patcheng @karwa