[6.3][cxx-interop] Fix crashing on recursive enums #86049
+32
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation: Checking whether an Enum can be exported to C++ included checking whether all the enum cases are exportable. When one of these cases refer to the original enum we got into an infinte recursion. This PR adds a cache that is also used to cut the recursion in these cases. Issues: rdar://164153038 Original PRs: swiftlang#85980 Risk: Low, this only adds a cache. Testing: Added a compiler test. Reviewers: @egorzhdan @j-hui @susmonteiro
Xazax-hun
added
c++ interop
Contributor
Author
|
@swift-ci please test |
egorzhdan
approved these changes
Dec 15, 2025
j-hui
approved these changes
Dec 16, 2025
Contributor
Author
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Checking whether an Enum can be exported to C++ included checking whether all the enum cases are exportable. When one of these cases refer to the original enum we got into an infinte recursion. This PR adds a cache that is also used to cut the recursion in these cases.
Issues: rdar://164153038
Original PRs: #85980
Risk: Low, this only adds a cache.
Testing: Added a compiler test.
Reviewers: @egorzhdan @j-hui @susmonteiro