Skip to content

[6.3][CAS|LLDB] Cleanup diagnostics in ExplicitCASModuleLoader #86062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cachemeifyoucan wants to merge 1 commit into
base: release/6.3
Choose a base branch
from
Open

[6.3][CAS|LLDB] Cleanup diagnostics in ExplicitCASModuleLoader #86062

cachemeifyoucan wants to merge 1 commit into from
+12 −3

Conversation

@cachemeifyoucan
Copy link
Contributor

@cachemeifyoucan cachemeifyoucan commented Dec 15, 2025 •
edited
Loading

  • Explanation: Cleanup some error diagnostics in ExplicitCASModuleLoader for LLDB's usage. This allows ExplicitCASModuleLoader to be used with other module loader as fallback without triggering an error when it failed to load.
  • Scope: This allows LLDB's new usage of ExplicitCASModuleLoader.
  • Issues: rdar://166490023
  • Original PRs: [CAS|LLDB] Cleanup diagnostics in ExplicitCASModuleLoader #86060
  • Risk: Low. Diagnostics Only.
  • Testing: Covered by LLDB tests.
  • Reviewers: @artemcm

@cachemeifyoucan
[CAS|LLDB] Cleanup diagnostics in ExplicitCASModuleLoader
5451a22 
While configuring LLDB to use ExplicitCASModuleLoader, it enounters some
error diagnostics that causes module loading to fail, rather than fall
back to the next module loader.

This commit clears:
* Allow ExplicitCASModuleLoader to be initialized with an empty explicit
  module map CASID
* Do not trigger error diagnostics when module lookup failed in module
  dependency scanner.

rdar://166490023
@cachemeifyoucan cachemeifyoucan requested a review from a team as a code owner December 15, 2025 18:01
@cachemeifyoucan
Copy link
Contributor Author

cachemeifyoucan commented Dec 15, 2025

@swift-ci please test

@cachemeifyoucan
Copy link
Contributor Author

cachemeifyoucan commented Dec 15, 2025

@swift-ci please test windows platform

1 similar comment
@cachemeifyoucan
Copy link
Contributor Author

cachemeifyoucan commented Dec 16, 2025

@swift-ci please test windows platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrian-prantl adrian-prantl Awaiting requested review from adrian-prantl

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cachemeifyoucan