[cmake, 6.3] fix libswiftCompatibilitySpan for maccatalyst builds #86071
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some build configurations, libswiftCompatibilitySpan was being linked for a newer deployment target than expected.
Contributor
Author
|
@swift-ci please test |
DougGregor
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: In some build configurations, libswiftCompatibilitySpan was being linked for a newer deployment target than expected. With this fix the maccatalyst deployment target no longer overwrites the macOS deployment target at link time.
Resolves: rdar://163874201
Risk: Low. This only affects macOS builds, where the deployment target of libswiftCompatibilitySpan is already wrong (macOS 13.1,) instead of the expected value of macOS 10.14.4 for x86_64, or macOS 11 for arm64.
Main branch PR: [cmake] fix libswiftCompatibilitySpan for maccatalyst builds #85969
Reviewed by: @edymtt
Testing: Verified libraries created by a side build. This should allow the macOS back-deployment tests to now successfully execute the Span-related tests.