[CSBindings] Store the originator type variable in a transitive binding #86072
Conversation
Instead of using a flag in `addBinding`, let's record what type variable does the binding belong to in `PotentialBinding` itself. This is going to help remove bindings introduced transitively when the inference is done lazily.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
| auto type = binding.BindingType; | ||
|
|
||
| if (isTransitive && !checkTypeOfBinding(TypeVar, type)) | ||
| if (binding.isTransitive() && !checkTypeOfBinding(TypeVar, type)) |
There was a problem hiding this comment.
I know this isn't the focus of this PR, but checkTypeOfBinding() seems to be generally applicable and not just in the case of transitive bindings, for example there's an occurs check. Why do we only do this check for transitive bindings? Are they always true by construction for non-transitive bindings? Should we ASSERT(checkTypeOfBinding(TypeVar, type)) then?
There was a problem hiding this comment.
checkTypeOfBinding for a direct binding happens as part of inferFromRelational, here we double-check that it's indeed okay to transfer because it didn't get checked for the current type variable.
There was a problem hiding this comment.
ah ok, is it worth adding that assert then?
There was a problem hiding this comment.
It's somewhat expensive if type has type variables because they have to be collected, so I'm not sure whether it's really worth it...
|
@swift-ci please test Windows platform |
2 participants
Instead of using a flag in
addBinding, let's record what type variable does the binding belong to inPotentialBindingitself. This is going to help remove bindings introduced transitively when the inference is done lazily.