[Dependency Scanning] Add tracking of the number of dependency queries and emit them as remarks #86079
+205
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and emit them as remarks This change adds collection of three metrics to the scanner: - number of Swift module lookups - number of named Clang module lookups - recorded number of Clang modules which were imported into a Swift module by name It re-uses the prior '-Rdependency-scan-cache', renaming it to '-Rdependency-scan' and adds emission of the above metrics as remarks when this flag is enabled. Followup changes will add further remarks about dependency scanner progress.
artemcm
requested review from
cachemeifyoucan,
hborla,
slavapestov,
tshortli and
xedin
as code owners
Contributor
Author
|
@swift-ci test |
artemcm
commented
Dec 16, 2025
|
|
||
| // CHECK-REMARK-SAVE: remark: Number of Swift module queries: '21' | ||
| // CHECK-REMARK-SAVE: remark: Number of named Clang module queries: '6' | ||
| // CHECK-REMARK-SAVE: remark: Number of recorded Clang module dependencies queried by-name from a Swift client: '6' |
Contributor
Author
There was a problem hiding this comment.
Although it may be prudent to, one day, make the compiler assert/error if the number of queries exceeds the number of recorded by-name Clang dependencies, we are not quite there yet. I have a couple of follow-up changes in the pipeline which should remove further sources of duplicate queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds collection of three metrics to the scanner:
It re-uses the prior '-Rdependency-scan-cache', renaming it to '-Rdependency-scan' and adds emission of the above metrics as remarks when this flag is enabled. Followup changes will add further remarks about dependency scanner progress.