Add support for internazionalization to Swing Music #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…er to save the language settings.
Author
|
This feature is now ready to be tested properly. The only part that might need some additional work is the HTML selector, but CSS/design is not my forte, so if someone want to pick up that part I would be grateful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the work started in #50 and add an attempt of language selector (webdev is not my field of expertise, so further improvements are welcome).
Need a proper testing, since I haven't tried with both backend and frontend online, yet.
Depends on swingmx/swingmusic#417 for the field in the user database.Not needed anymore, client side cookie is easier to manage.