Simulate PR 3214 #71
Merged
Simulate PR 3214 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0abf45e.
Updated the test workflow to fail if a security issue is found
Added `minimum` option to `KSComp`
Removed unnecessary setup() from doc page
…mpty_subsystems Fix relevance check for empty groups
Update version/notes for 3.33.0 release
Increment version to 3.33.1-dev
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
This pull request will transition POEM_094 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first of several implementation changes in support of POEM 094.
Users were finding the fact that run_driver returned
Trueif something had failed to be confusing.To address this, a new
DriverResultobject has been added, containing the information previously stored indriver.opt_result.This DriverResult object exists for all drivers, including non-optimization ones, so it is now stored in
Driver.result.Previously, ScipyOptimizeDriver stored scipy's OptimizeResult object as
driver.result, but this is now changed toscipy_optimize_result.DOEDriver now successfully populates the attributes of
DriverResult.Hooks have been added, though not yet implemented, to allow drivers to add driver/optimizer-specific attributes to the DriverResults object.
DriverResult currently overrides
__bool__with a deprecation warning to retain existing behavior.Related Issues
Backwards incompatibilities
ScipyOptimizeDriver.resultis now a DriverResults object. Scipy-specific OptimizeResult objects are now stored inScipyOptimizeDriver._scipy_optimize_result, though some of this information will be added to the DriverResult object.New Dependencies
None