forked from AppPear/ChartView
-
Notifications
You must be signed in to change notification settings - Fork 0
1 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sy1995
wants to merge
75
commits into
sy1995:master
Choose a base branch
from
AppPear:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add rateValue to LineChart * modify * modify rate value to linechart * modify * modify
Changed Int to Double in quadCurvedPathWithPoints and quadClosedCurvedPathWithPoints.
…Bar chart, added ability to change ecg image in the corner, added Generic number types to ChartData initialiser
I added ChartView/SwiftUICharts to my iphone project. It worked as
expected until I tried to archive the application for distribution.
In the archive step, compilation fails with a segmentation fault:
1. While running pass #48703 SILFunctionTransform "GenericSpecializer" on SILFunction "@$s13SwiftUICharts9ChartDataC6pointsACSayxG_tcSBRzlufcSd_Tg5".
for 'init(points:)' (at /Users/kfowler/projects/ChartView/Sources/SwiftUICharts/Helpers.swift:134:12)
0 swift 0x0000000113b94a63 PrintStackTraceSignalHandler(void*) + 51
1 swift 0x0000000113b94236 SignalHandler(int) + 358
2 libsystem_platform.dylib 0x00007fff6bd7d42d _sigtramp + 29
3 libsystem_platform.dylib 0x0000000800000001 _sigtramp + 2485660657
4 swift 0x000000010ffd800c swift::ReabstractionInfo::prepareAndCheck(swift::ApplySite, swift::SILFunction*, swift::SubstitutionMap, swift::OptRemark::Emitter*) + 572
5 swift 0x000000011002abda swift::ReabstractionInfo::ReabstractionInfo(swift::ApplySite, swift::SILFunction*, swift::SubstitutionMap, swift::IsSerialized_t, bool, swift::OptRemark::Emitter*) + 122
6 swift 0x0000000110034c35 swift::trySpecializeApplyOfGeneric(swift::SILOptFunctionBuilder&, swift::ApplySite, llvm::SmallSetVector<swift::SILInstruction*, 8u>&, llvm::SmallVectorImpl<swift::SILFunction*>&, swift::OptRemark::Emitter&) + 1653
7 swift 0x000000010ff0d731 (anonymous namespace)::GenericSpecializer::run() + 2673
8 swift 0x000000010fe86f3e swift::SILPassManager::execute() + 4606
9 swift 0x000000010fae596b swift::CompilerInstance::performSILProcessing(swift::SILModule*, swift::UnifiedStatsReporter*) + 6379
10 swift 0x000000010f7ddec5 performCompile(swift::CompilerInstance&, swift::CompilerInvocation&, llvm::ArrayRef<char const*>, int&, swift::FrontendObserver*, swift::UnifiedStatsReporter*) + 33925
11 swift 0x000000010f7d2234 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 6820
12 swift 0x000000010f75f733 main + 1219
13 libdyld.dylib 0x00007fff6bb847fd start + 1
error: Segmentation fault: 11 (in target 'SwiftUICharts' from project 'SwiftUICharts')
This change resolves the issue.
…neview, linechartview, barchartview
#123) * Cleanup the explicitly unwrapped parameters which had a default value anyway * Remove print statement
* add `keepTouchLocation` to let us choose whether touchLocation is back to -1 after label has been dragged. * keep showing value if `keepTouchLocation` is true. * Update README.md * feat: when `keepTouchLocation` is true, bar is automatically deselect in a second after a gesture. * fix: (BarChart) add animation when back to initial position after completing your gesture. and rename keepTouchLocation to animatedToBack.
Remove .drawingGroup() to draw Lines again.
* Make the line reach the top and bottom of the chart. * Put the Magnifier's bottom edge on the 0 line.
Co-authored-by: ClaesCJ <claes@airwallet.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1