fix: add x509v3 extensions for CA and node certificates in configuration#19
Open
ccHarvestasya wants to merge 1 commit intosymbol:devfrom
Open
fix: add x509v3 extensions for CA and node certificates in configuration#19ccHarvestasya wants to merge 1 commit intosymbol:devfrom
ccHarvestasya wants to merge 1 commit intosymbol:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates the certificate generation process to support x509 v3 certificates.
It introduces the logic required for v3 certificate creation and adjusts related test cases accordingly.
Details
I have added a test that checks for x509v3, but it uses the
opensslcommand, so it depends on the execution environment and might be better not to have it...Please review and let me know if further changes are needed.