Skip to content

Add configuration option to not link NPC HP token bar#98

Open
liquidox wants to merge 24 commits intosymposion:masterfrom
liquidox:master
Open

Add configuration option to not link NPC HP token bar#98
liquidox wants to merge 24 commits intosymposion:masterfrom
liquidox:master

Conversation

@liquidox
Copy link

@liquidox liquidox commented Mar 24, 2017

Not sure if you are taking PR's, but I wanted to give this a try, fixing a minor peeve of mine.

For me this resolves Roll20#402, as it's actually the only use case I have for it.

Please don't mind the long list of commits, the actual changes are quite small...

@symposion
Copy link
Owner

Hey, so you've done this the really hard way! :-) The code in this project is actually a generated file. The original code is modularised and has unit tests and a proper build system and it lives over here:
https://github.com/symposion/roll20-shaped-scripts
I can apply your changes manually to that code, but in future that's the place to submit PRs. If you're not already familiar with npm and gulp you might have a slight learning curve - basically you need to install nodejs and then run 'npm install' in the project directory, followed by 'gulp' to run the build.

@symposion
Copy link
Owner

Also, for future use, when submitting a PR you should learn the magic of squashing commits with interactive rebase in git. See e.g. http://push.cwcon.org/learn/squashing-commits.html

@liquidox
Copy link
Author

Ah was wondering, I should have looked harder... have used webpack and node before. I'll also look into playing squash, thanks for the tips!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants