Update deploy-zksync.sh #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some minor fixes.... -I added quotes in conditions like "$2", this is It prevents us from getting an error when the variable content is empty. - I added quotes in commands like rm -rf"./artifacts-zk" and rm -rf "./cache-zk", this prevents us from getting errors if the file or directory name contains spaces. - if [[ "$skipped Compile" == 0 && "$1" ]]; then and if [[ "$skipped Compile" == 1 && "$2" ]]; I added spaces in if conditions like then and quoted $1 and $2, which prevents us from getting an error if the variables are empty. - I added quotes in expressions such as script="$1" and script="$2" to assign a value to the script variable. - For checking a non-null variable [[! I added quotes using -z "$script"]]. I thought these changes would make the code run more reliably and consistently. If I make a mistake, please let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor fixes....
-I added quotes in conditions like "$2", this is
It prevents us from getting an error when the variable content is empty.
I thought these changes would make the code run more reliably and consistently. If I make a mistake, please let me know.