chore: simplify pin options #592
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies PIN authentication by making PIN-on-launch the default behavior when PIN is enabled, while removing the PIN-on-idle feature. This aligns with the Figma V59 design specifications.
Changes:
- Removed PIN-on-launch toggle option since it's now the default behavior when PIN is enabled
- Removed PIN-on-idle feature entirely including its UI components and lifecycle tracking
- Updated authentication logic to check only
isPinEnabledinstead of bothisPinEnabledandisPinOnLaunchEnabled
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/src/main/java/to/bitkit/viewmodels/SettingsViewModel.kt | Removed isPinOnIdleEnabled and isPinOnLaunchEnabled state flows and their setters |
| app/src/main/java/to/bitkit/viewmodels/AppViewModel.kt | Simplified authentication check to only verify isPinEnabled and removed isPinOnLaunchEnabled setting when adding PIN |
| app/src/main/java/to/bitkit/ui/settings/SecuritySettingsScreen.kt | Removed PIN-on-launch and PIN-on-idle UI switches and their navigation handlers |
| app/src/main/java/to/bitkit/ui/components/InactivityTracker.kt | Deleted entire file as PIN-on-idle feature is removed |
| app/src/main/java/to/bitkit/ui/components/AuthCheckScreen.kt | Removed TOGGLE_PIN_ON_LAUNCH and TOGGLE_PIN_ON_IDLE action handlers |
| app/src/main/java/to/bitkit/ui/MainActivity.kt | Removed InactivityTracker wrapper component |
| app/src/main/java/to/bitkit/services/MigrationService.kt | Removed isPinOnLaunchEnabled and isPinOnIdleEnabled fields from settings migration |
| app/src/main/java/to/bitkit/data/SettingsStore.kt | Removed isPinOnLaunchEnabled and isPinOnIdleEnabled from SettingsData model |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #421
Fix #542
Figma
Description
This PR updates the Pin options according the Figma V59 version. Now pinOnLaunch is the default behavior when PIN is enabled, and pin on idle was removed
Preview
Screen_recording_20260109_115231.mp4
QA Notes