-
Notifications
You must be signed in to change notification settings - Fork 1
Test/transfer #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Test/transfer #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds end-to-end test support by introducing accessibility identifiers throughout the transfer flow UI and adding unit tests for critical view models. It also includes bug fixes for channel numbering display and pending order filtering logic.
- Adds comprehensive accessibility identifiers to transfer-related views for e2e test automation
- Introduces unit tests for
TransferViewModel.displayOrder()andChannelDetailsViewModel.pendingOrders() - Fixes channel numbering to display in descending order (newest first) in Lightning Connections view
- Updates
SpendingConfirmto use thedisplayOrderpattern for consistent order state management - Refactors
ChannelDetailsViewModelto filter pending orders by paid status, aligning with Android/RN behavior
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| BitkitTests/TransferViewModelTests.swift | New test file validating displayOrder method prefers UI state over fallback |
| BitkitTests/ChannelDetailsViewModelTests.swift | New test file validating pending orders filtering by paid status and state |
| Bitkit/ViewModels/TransferViewModel.swift | Adds displayOrder helper method to prioritize UI state order |
| Bitkit/ViewModels/ChannelDetailsViewModel.swift | Updates pending orders logic to filter by paid order IDs from transfer storage |
| Bitkit/Views/Transfer/SpendingConfirm.swift | Refactors to use displayOrder pattern for consistent order state |
| Bitkit/Views/Settings/Advanced/LightningConnectionsView.swift | Fixes channel numbering to show newest channels first |
| Bitkit/Components/NumberPadTextField.swift | Moves accessibility identifier from inner view to parent for better test targeting |
| Bitkit/Views/Wallets/SpendingWalletView.swift | Adds "TransferToSavings" accessibility identifier |
| Bitkit/Views/Wallets/SavingsWalletView.swift | Adds "TransferToSpending" accessibility identifier |
| Bitkit/Views/Transfer/TransferLearnMoreView.swift | Adds "LiquidityContinue" accessibility identifier |
| Bitkit/Views/Transfer/SpendingAmount.swift | Adds accessibility identifiers for continue, quarter, and max buttons |
| Bitkit/Views/Transfer/SpendingAdvancedView.swift | Adds accessibility identifiers for number field and action buttons |
| Bitkit/Views/Transfer/SettingUpView.swift | Adds accessibility identifiers for loading and success states |
| Bitkit/Views/Transfer/SavingsProgressView.swift | Adds conditional accessibility identifiers for success state |
| Bitkit/Views/Transfer/SavingsAvailabilityView.swift | Adds "AvailabilityContinue" accessibility identifier |
| Bitkit/Views/Transfer/FundManualAmountView.swift | Adds "ExternalAmountContinue" accessibility identifier |
| Bitkit/Views/Wallets/Receive/ReceiveEdit.swift | Refactors to pass testIdentifier as parameter to NumberPadTextField |
Description
Changes to enable
@transfere2e tests.Should fix: #281, #286.
Linked Issues/Tasks
Screenshot / Video
Insert relevant screenshot / recording