Skip to content

Conversation

@piotr-iohk
Copy link
Collaborator

@piotr-iohk piotr-iohk commented Dec 19, 2025

Description

Changes to enable @transfer e2e tests.
Should fix: #281, #286.

Linked Issues/Tasks

Screenshot / Video

Insert relevant screenshot / recording

@piotr-iohk piotr-iohk self-assigned this Dec 19, 2025
@piotr-iohk piotr-iohk marked this pull request as ready for review December 23, 2025 07:47
@piotr-iohk piotr-iohk requested a review from Copilot December 23, 2025 07:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds end-to-end test support by introducing accessibility identifiers throughout the transfer flow UI and adding unit tests for critical view models. It also includes bug fixes for channel numbering display and pending order filtering logic.

  • Adds comprehensive accessibility identifiers to transfer-related views for e2e test automation
  • Introduces unit tests for TransferViewModel.displayOrder() and ChannelDetailsViewModel.pendingOrders()
  • Fixes channel numbering to display in descending order (newest first) in Lightning Connections view
  • Updates SpendingConfirm to use the displayOrder pattern for consistent order state management
  • Refactors ChannelDetailsViewModel to filter pending orders by paid status, aligning with Android/RN behavior

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
BitkitTests/TransferViewModelTests.swift New test file validating displayOrder method prefers UI state over fallback
BitkitTests/ChannelDetailsViewModelTests.swift New test file validating pending orders filtering by paid status and state
Bitkit/ViewModels/TransferViewModel.swift Adds displayOrder helper method to prioritize UI state order
Bitkit/ViewModels/ChannelDetailsViewModel.swift Updates pending orders logic to filter by paid order IDs from transfer storage
Bitkit/Views/Transfer/SpendingConfirm.swift Refactors to use displayOrder pattern for consistent order state
Bitkit/Views/Settings/Advanced/LightningConnectionsView.swift Fixes channel numbering to show newest channels first
Bitkit/Components/NumberPadTextField.swift Moves accessibility identifier from inner view to parent for better test targeting
Bitkit/Views/Wallets/SpendingWalletView.swift Adds "TransferToSavings" accessibility identifier
Bitkit/Views/Wallets/SavingsWalletView.swift Adds "TransferToSpending" accessibility identifier
Bitkit/Views/Transfer/TransferLearnMoreView.swift Adds "LiquidityContinue" accessibility identifier
Bitkit/Views/Transfer/SpendingAmount.swift Adds accessibility identifiers for continue, quarter, and max buttons
Bitkit/Views/Transfer/SpendingAdvancedView.swift Adds accessibility identifiers for number field and action buttons
Bitkit/Views/Transfer/SettingUpView.swift Adds accessibility identifiers for loading and success states
Bitkit/Views/Transfer/SavingsProgressView.swift Adds conditional accessibility identifiers for success state
Bitkit/Views/Transfer/SavingsAvailabilityView.swift Adds "AvailabilityContinue" accessibility identifier
Bitkit/Views/Transfer/FundManualAmountView.swift Adds "ExternalAmountContinue" accessibility identifier
Bitkit/Views/Wallets/Receive/ReceiveEdit.swift Refactors to pass testIdentifier as parameter to NumberPadTextField

@piotr-iohk piotr-iohk requested review from jvsena42 and pwltr December 23, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transfer to spending: receiving capacity not updated

2 participants