Let SQL generator match non-case-folded implementor name to provides string
#519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DDRProcessor creates an implied dependency of an 'implementor' name on the SQLAction carrying a matching 'provides' string. An implementor name, per ISO SQL/JRT, is an SQL identifier, case-insensitive unless quoted. But a PL/Java 'provides' string is just a string, with only case-sensitive exact matching. The DDRProcessor was using a surprising and undocumented rule, matching only if the provides string was identical to the implementor name's lower-case-folded form. The results could be especially puzzling because the 'weak' nature of the implementor/provides dependency meant there was no error or warning of the failue to match. The dependency simply wasn't created, leading possibly to an incorrectly-ordered deployment descriptor. Rather than some more general and complicated solution, simply change the rule so the provider string is matched to the non-folded implementor name as it was spelled in the source annotation. Thus as long as the programmer does the expected thing and spells them the same in the source, the right thing happens. Addresses #515.
This had never been well documented. The javadoc of the ConditionalDDR example code was about the best there was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DDRProcessorcreates an implied dependency of animplementorname on theSQLActioncarrying a matchingprovidesstring. An implementor name, per ISO SQL/JRT, is an SQL identifier, case-insensitive unless quoted. But a PL/Javaprovidesstring is just a string, with only case-sensitive exact matching. TheDDRProcessorwas using a surprising and undocumented rule, matching only if theprovidesstring was identical to theimplementorname's lower-case-folded form.The results could be especially puzzling because the 'weak' nature of the
implementor/providesdependency meant there was no error or warning of the failure to match. The dependency simply wasn't created, leading possibly to an incorrectly-ordered deployment descriptor.Rather than some more general and complicated solution, simply change the rule so the
providesstring is matched to the non-foldedimplementorname as it was spelled in the source annotation. Thus as long as the programmer does the expected thing and spells them the same in the source, the right thing happens.Addresses issue #515.