-
Notifications
You must be signed in to change notification settings - Fork 9
Node 0.6 compatibility #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Eliminates deprecation warning under Node 0.6
|
this solves issue with 0.6. |
|
+1 |
4 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 could you please merge this pull request, because i dont want to use trevors branch if not necessary... |
|
you can use |
|
alright, ty matjaz |
|
Perhaps less pressing, but the value of ENOENT also looks like it has changed. The value in the in node 0.6.11 is now 34 (defined on line 105 of deps/uv/include/uv.h). node-watch-tree has it specified as 2. |
|
you can't rely on error.errno. But I guess you can check error.code property. |
Anyone who uses node-watch-tree under Node 0.6 on a directory with files in it is going to get an error
It turns out the reason is—somewhat bafflingly—that the error code for
ENOTDIRchanged from 20 to 27, so the testerr.errno == ENOTDIRin [stat.coffee[(https://github.com/tafa/node-watch-tree/blob/master/src/watchers/stat.coffee) fails. This patch changes the currenterr.errnochecks toerr.codechecks. All tests pass.Also,
require 'util'is used instead ofrequire 'sys'when running tests, since doingrequire 'sys'generates the distracting deprecation message