641: bun shell wip by tahminator · Pull Request #665 · tahminator/codebloom

tahminator · 2026-01-16T01:03:13Z

641 Description of changes

Checklist before review

I have done a thorough self-review of the PR
Copilot has reviewed my latest changes, and all comments have been fixed and/or closed.
If I have made database changes, I have made sure I followed all the db repo rules listed in the wiki here. (check if no db changes)
All tests have passed
I have successfully deployed this PR to staging
I have done manual QA in both dev (and staging if possible) and attached screenshots below.

Screenshots

Dev

Staging

github-actions · 2026-01-16T01:03:23Z

Available PR Commands

/ai - Triggers all AI review commands at once
/review - AI review of the PR changes
/describe - AI-powered description of the PR
/improve - AI-powered suggestions
/deploy - Deploy to staging

See: https://github.com/tahminator/codebloom/wiki/CI-Commands

github-actions · 2026-01-16T01:04:17Z

Title

641: wip

PR Type

Enhancement, Other

Description

Replace bash CI script with Bun TypeScript
Add Node, pnpm, Bun setup in workflow
Introduce scripts package with lockfile
Add tsconfig for CI scripts

Diagram Walkthrough

flowchart LR
  BashScript["Bash script (.sh)"] -- replaced by --> BunTS["Bun TypeScript script (.ts)"]
  Workflow["GitHub Action composite"] -- setup Node/pnpm/Bun --> Env["Script runtime env"]
  Env -- installs --> Deps["scripts package deps"]
  BunTS -- runs --> Maven["Maven fmt/lint/verify"]

File Walkthrough

Relevant files

Enhancement

run-backend-compile-tests.ts `Add Bun TS script to run Maven checks` .github/scripts/run-backend-compile-tests.ts Add Bun TypeScript script runner Execute Maven spotless, checkstyle, and verify Provide success/failure exit handling	+21/-0

Miscellaneous

run-backend-compile-tests.sh `Remove legacy Bash CI script` .github/scripts/run-backend-compile-tests.sh Remove Bash script invoking Maven tasks	+0/-13

Configuration changes

action.yml `Update composite action to use Bun and pnpm` .github/composite/test/backend-pre-test/action.yml Setup pnpm and Node cache Install Bun runtime Install script dependencies with pnpm Switch run step to Bun TS script	+17/-1
tsconfig.json `Add TypeScript configuration for CI scripts` .github/scripts/tsconfig.json Add TypeScript config for scripts Enable strict, JS checking, and path aliases	+23/-0

Dependencies

package.json `Introduce package.json for CI scripts` .github/scripts/package.json Add scripts package metadata Declare bun and @types/bun dependencies Specify pnpm as packageManager	+16/-0
pnpm-lock.yaml `Add pnpm lockfile for scripts deps` .github/scripts/pnpm-lock.yaml Add lockfile for scripts dependencies Pin Bun and types packages	+155/-0

github-actions · 2026-01-16T01:04:30Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Execution Shell Mismatch The step invokes `bun .github/scripts/run-backend-compile-tests.ts` but the step's `shell` is set to `bash`. While GitHub defaults to using the runner shell regardless, explicitly specifying `bash` can be misleading and unnecessary for a Bun command. Consider removing `shell` or setting it appropriately to avoid confusion. - name: Run script shell: bash run: bun .github/scripts/run-backend-compile-tests.ts Unnecessary Dependency Adding `bun` as a runtime dependency may be redundant since the workflow installs Bun via `oven-sh/setup-bun`. Keeping it in `dependencies` bloats lockfile and can cause version drift with the action. Prefer relying on the action and removing the `bun` dependency, keeping only types in devDependencies if needed. "dependencies": { "bun": "^1.3.6" }, "devDependencies": { "@types/bun": "^1.3.6" } Caching/Install Scope `pnpm --dir .github/scripts install --frozen-lockfile` installs within the `.github/scripts` directory, but the workflow sets Node cache at repo root. Ensure cache keys and working dir align or set `actions/setup-node` cache-dependency-path to `.github/scripts/pnpm-lock.yaml` to get effective caching. - uses: actions/setup-node@v4 with: node-version: 20 cache: "pnpm" - uses: oven-sh/setup-bun@v2 with: bun-version: latest - name: Install deps run: pnpm --dir .github/scripts install --frozen-lockfile

github-actions · 2026-01-16T01:04:50Z

.github/scripts/test/run-backend-compile-tests.ts

+  await $`./mvnw checkstyle:check`;
+
+  // compile
+  await $`./mvnw -B verify -Dmaven.test.skip=true --no-transfer-progress`;


Suggestion: Use 'with' on '$' to fail early and stream output; also set a working directory to the repo root to avoid path issues. This ensures the Maven command inherits stdio and fails on non-zero exit reliably in Bun contexts. [possible issue, importance: 6]

Suggested change

await $`./mvnw -B verify -Dmaven.test.skip=true --no-transfer-progress`;

await $.cwd(process.cwd()).with({ stdin: 'inherit', stdout: 'inherit', stderr: 'inherit' })`./mvnw -B verify -Dmaven.test.skip=true --no-transfer-progress`;

github-actions · 2026-01-16T01:04:50Z

.github/scripts/test/run-backend-compile-tests.ts

+main()
+  .then(() => {
+    process.exit(0);
+  })
+  .catch((e) => {
+    console.error(e);
+    process.exit(1);
+  });


Suggestion: Avoid explicit process.exit calls; they can terminate before streams flush and mask unhandled rejections. Let the promise chain determine exit status by rethrowing or returning non-zero via shell. [general, importance: 7]

Suggested change

main()

.then(() => {

process.exit(0);

})

.catch((e) => {

console.error(e);

process.exit(1);

});

main().catch((e) => {

console.error(e);

// Non-zero exit by setting process.exitCode; allows stdout/stderr to flush.

process.exitCode = 1;

});

github-actions · 2026-01-16T01:04:50Z

.github/composite/test/backend-pre-test/action.yml

+    - name: Install deps
+      shell: bash
+      run: pnpm --dir .github/scripts install --frozen-lockfile
+


Suggestion: Pin the working directory using 'working-directory' instead of relying on '--dir' to avoid path resolution differences across runners. This reduces risk of installing in the wrong location. [general, importance: 6]

Suggested change

- name: Install deps

shell: bash

run: pnpm --dir .github/scripts install --frozen-lockfile

- name: Install deps

shell: bash

working-directory: .github/scripts

run: pnpm install --frozen-lockfile

codecov · 2026-01-16T01:15:24Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

tahminator · 2026-01-16T03:34:53Z

/ai

tahminator · 2026-01-16T03:35:24Z

/review

tahminator · 2026-01-16T03:35:25Z

/describe

tahminator · 2026-01-16T03:35:26Z

/improve

github-actions · 2026-01-16T03:36:25Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Error handling If postgres doesn't become ready or migration fails, the script logs and calls end() but does not exit with non-zero status, which may let CI proceed despite failure. Consider throwing after end() or process.exit(1) to fail fast. if (!ready) { console.error("postgres failed to start in time."); end(); } process.env.DATABASE_HOST = "localhost"; process.env.DATABASE_PORT = "5440"; process.env.DATABASE_NAME = "codebloom"; process.env.DATABASE_USER = "postgres"; process.env.DATABASE_PASSWORD = "postgres"; console.log("postres started, running migrations..."); await $`./mvnw flyway:migrate -Dflyway.locations=filesystem:./db`; console.log("postgres ready"); } catch (e) { console.error(e); end(); } Process cleanup start() calls end() on failure but does not await it, and does not set non-zero exit; also be.kill() may not terminate child tree (mvn + java). Consider awaiting end(), ensuring non-zero exit, and using proper signal/kill group if needed. if (!ready) { console.error("Backend failed to start in time."); end(); } console.log("backend ready"); } catch (e) { console.error(e); end(); } Shell step portability Uses a compound shell command with cd and script invocation in one template literal; if path contains spaces or if run from a different CWD, this may be brittle. Prefer --cwd flags or separate steps to ensure reliable execution. await $`corepack enable pnpm`; await $`cd email && pnpm i --frozen-lockfile && ./email.sh && cd ..`;

.github/scripts/utils/run-backend-instance.ts

.github/scripts/utils/run-local-db.ts

.github/scripts/utils/run-backend-instance.ts

github-actions · 2026-01-16T03:36:39Z

Title

641: wip

PR Type

Enhancement

Description

Replace bash scripts with Bun TypeScript
Add ANSI color utilities for logs
Update CI to setup and use Bun
Improve AI review with Notion context

Diagram Walkthrough

flowchart LR
  Bash["Legacy bash scripts"] -- replaced by --> BunTS["Bun TypeScript scripts"]
  BunTS -- used in --> CIBackend["CI: Backend tests"]
  BunTS -- used in --> CIFrontend["CI: Frontend tests"]
  Colors["ANSI color helpers"] -- improve logs --> BunTS
  Workflows["GitHub Actions workflows"] -- setup bun/cache/run --> CIBackend
  Workflows -- setup bun/cache/run --> CIFrontend
  AIReview["AI review workflow"] -- add Notion context & tuning --> Workflows

File Walkthrough

Relevant files

Enhancement

6 files

colors.ts `Add ANSI color formatting helpers`	+103/-0
run-backend-instance.ts `Implement backend runner with readiness checks`	+73/-0
run-local-db.ts `Implement Postgres lifecycle and migration runner`	+84/-0
run-backend-compile-tests.ts `Port backend compile/lint to Bun script`	+21/-0
run-backend-tests.ts `Port backend tests pipeline to Bun`	+29/-0
run-frontend-tests.ts `Port frontend e2e tests pipeline to Bun`	+27/-0

Miscellaneous

5 files

local-db.sh `Remove bash-based local DB management`	+0/-52
run-backend-compile-tests.sh `Remove bash backend compile script`	+0/-13
run-backend-instance.sh `Remove bash backend instance runner`	+0/-38
run-backend-tests.sh `Remove bash backend tests script`	+0/-26
run-frontend-tests.sh `Remove bash frontend tests script`	+0/-15

Configuration changes

4 files

action.yml `Setup Bun and run TS compile script`	+18/-1
tsconfig.json `Add TypeScript config for Bun scripts`	+29/-0
ai-review.yml `Add Notion context and tune PR reviewer`	+19/-1
ci-cd.yml `Use Bun in CI for backend/frontend scripts`	+36/-7

Dependencies

1 files

package.json `Add scripts package with Bun deps`	+15/-0

.github/composite/load-secrets/action.yml

github-actions · 2026-01-18T17:41:40Z

The command to deploy to staging for the commit ffd1171 has been triggered. View action run

641: wip fix coloring 641: wip fix coloring pt2 641: update ai review 641: add load-secrets 641: add load-secrets pt2 641: add load-secrets pt3 641: add load-secrets pt4 641: add load-secrets pt5 fix writing logic 641: add load-secrets pt5 fix writing logic wdekfjnewkgfn

.github/scripts/build-image.ts

github-actions · 2026-01-19T08:07:54Z

The command to deploy to staging for the commit 3219f77 has been triggered. View action run

github-actions · 2026-01-19T08:11:04Z

Staging deployment was cancelled for commit 3219f77

View run

github-actions · 2026-01-19T08:11:20Z

The command to deploy to staging for the commit c22dd06 has been triggered. View action run

github-actions · 2026-01-19T08:12:55Z

Staging deployment failed for commit c22dd06

View run

github-actions · 2026-01-19T08:14:19Z

The command to deploy to staging for the commit 322e07d has been triggered. View action run

github-actions · 2026-01-19T08:24:05Z

Staging deployment succeeded for commit 322e07d

View run

.github/composite/notion-checks/action.yml

github-actions · 2026-01-19T09:01:48Z

The command to deploy to staging for the commit bdd3e47 has been triggered. View action run

.github/composite/setup-ci/action.yml

github-actions · 2026-01-19T09:10:37Z

Staging deployment succeeded for commit bdd3e47

View run

tahminator · 2026-01-19T09:14:20Z

/review

tahminator · 2026-01-19T09:14:21Z

/describe

tahminator · 2026-01-19T09:14:21Z

/improve

tahminator · 2026-01-19T09:16:32Z

/review

tahminator force-pushed the 641 branch 2 times, most recently from 67c5fe1 to a6ba20b Compare January 16, 2026 01:04

github-actions bot reviewed Jan 16, 2026

View reviewed changes

tahminator force-pushed the 641 branch from a6ba20b to ad20c48 Compare January 16, 2026 01:07

tahminator force-pushed the 641 branch 4 times, most recently from 83c86aa to 933567d Compare January 16, 2026 03:34

github-actions bot reviewed Jan 16, 2026

View reviewed changes

.github/scripts/utils/run-backend-instance.ts Show resolved Hide resolved

.github/scripts/utils/run-local-db.ts Show resolved Hide resolved

.github/scripts/utils/run-backend-instance.ts Show resolved Hide resolved

tahminator force-pushed the 641 branch from ae52f6e to a0f74d9 Compare January 16, 2026 04:21

github-advanced-security bot found potential problems Jan 16, 2026

View reviewed changes

.github/composite/load-secrets/action.yml Fixed Show fixed Hide fixed

tahminator force-pushed the 641 branch 2 times, most recently from ad14ed7 to ffd1171 Compare January 18, 2026 17:40

tahminator added 6 commits January 18, 2026 12:46

641: wip

0717b5d

641: wip pt2

9f30e99

641: wip pt3

3337b03

641: wip fix coloring 641: wip fix coloring pt2 641: update ai review 641: add load-secrets 641: add load-secrets pt2 641: add load-secrets pt3 641: add load-secrets pt4 641: add load-secrets pt5 fix writing logic 641: add load-secrets pt5 fix writing logic wdekfjnewkgfn

641: blee bloo bleeeeeeee

a6819a7

641: blee bloo bleeeeeeee wefklfkenfwekjnfg

07f39cf

641: blee

9e2b54a

641: test pt81

1d4e61a

github-advanced-security bot found potential problems Jan 19, 2026

View reviewed changes

.github/scripts/build-image.ts Fixed Show fixed Hide fixed

tahminator added 3 commits January 19, 2026 02:55

641: test pt82

f089861

641: test pt83

273a953

641: test pt84

3219f77

641: test pt85

c22dd06

641: test pt86

322e07d

641: testing 3

bdd3e47

tahminator force-pushed the 641 branch from c1ddb68 to bdd3e47 Compare January 19, 2026 08:57

github-advanced-security bot found potential problems Jan 19, 2026

View reviewed changes

.github/composite/notion-checks/action.yml Dismissed Show dismissed Hide dismissed

.github/composite/notion-checks/action.yml Dismissed Show dismissed Hide dismissed

tahminator added 2 commits January 19, 2026 04:02

641: testingggg

013a545

641: fixes

85d8229

github-advanced-security bot found potential problems Jan 19, 2026

View reviewed changes

.github/composite/setup-ci/action.yml Dismissed Show dismissed Hide dismissed

.github/composite/setup-ci/action.yml Dismissed Show dismissed Hide dismissed

tahminator added 2 commits January 19, 2026 04:09

641: fixes2

e8e796f

641: fixes3

2c271c2

tahminator added 2 commits January 19, 2026 04:12

641: fixes4

04667c1

641: fixes5

c12aa3c

tahminator closed this Jan 19, 2026

	await $`./mvnw -B verify -Dmaven.test.skip=true --no-transfer-progress`;
	await $.cwd(process.cwd()).with({ stdin: 'inherit', stdout: 'inherit', stderr: 'inherit' })`./mvnw -B verify -Dmaven.test.skip=true --no-transfer-progress`;

Conversation

tahminator commented Jan 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

641

Description of changes

Checklist before review

Screenshots

Dev

Staging

Uh oh!

github-actions bot commented Jan 16, 2026

Available PR Commands

Uh oh!

github-actions bot commented Jan 16, 2026

Title

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

github-actions bot commented Jan 16, 2026

PR Reviewer Guide 🔍

Uh oh!

github-actions bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 16, 2026

Codecov Report

Uh oh!

tahminator commented Jan 16, 2026

Uh oh!

tahminator commented Jan 16, 2026

Uh oh!

tahminator commented Jan 16, 2026

Uh oh!

tahminator commented Jan 16, 2026

Uh oh!

github-actions bot commented Jan 16, 2026

PR Reviewer Guide 🔍

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 16, 2026

Title

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 19, 2026

Uh oh!

tahminator commented Jan 16, 2026 •

edited by github-actions bot

Loading