Fixes #64: Add support for HTTPS query type (type 65)#47
Open
capveg-netdebug wants to merge 3 commits intotailhook:masterfrom
Open
Fixes #64: Add support for HTTPS query type (type 65)#47capveg-netdebug wants to merge 3 commits intotailhook:masterfrom
capveg-netdebug wants to merge 3 commits intotailhook:masterfrom
Conversation
capveg-netdebug
changed the title
Summary: I was getting 'query type 65 is invalid' errors parsing DNS packets on my machine and this fixes it. Test Plan: Added a unit test that parses a wild packet... it works <shrug>
capveg-netdebug
changed the title
capveg-netdebug
force-pushed
the
pr47
branch
from
827d13d to
dc5c4a3
Compare
|
Agree, getting error when trying to parse packet from wireshark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64: Add support for HTTPS query type (type 65)
Summary:
I was getting 'query type 65 is invalid' errors parsing DNS packets
on my machine and this fixes it.
Test Plan:
Added a unit test that parses a wild packet... it works