conn,device: implement InitiationAwareEndpoint #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be implemented by [magicsock.lazyEndpoint], which is responsible for triggering JIT peer configuration. Updates tailscale/corp#20732 Updates tailscale/corp#30042 Signed-off-by: Jordan Whited <jordan@tailscale.com>
There was a problem hiding this comment.
Pull Request Overview
Adds support for an InitiationAwareEndpoint to trigger just-in-time peer configuration when a WireGuard handshake initiation is received.
- Extends
ConsumeMessageInitiationto accept anEndpointand notify it of the initiator’s public key. - Defines the new
InitiationAwareEndpointinterface inconn/conn.go. - Updates existing callers (
device/receive.go,noise_test.go) and adds a test stub for the new interface.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| device/receive.go | Updated ConsumeMessageInitiation calls to pass the endpoint |
| device/noise-test.go | Added initAwareEP stub and test assertions for the new interface |
| device/noise-protocol.go | Changed ConsumeMessageInitiation signature and invokes the new callback |
| conn/conn.go | Introduced InitiationAwareEndpoint interface and documentation |
Comments suppressed due to low confidence (1)
conn/conn.go:89
- [nitpick] Use backticks instead of square brackets around type references in Go doc comments (e.g.,
EndpointandPeerAwareEndpoint) so that tools likego doclink them properly.
// InitiationAwareEndpoint is an optional [Endpoint] specialization for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be implemented by [magicsock.lazyEndpoint], which is responsible for triggering JIT peer configuration.
Updates tailscale/corp#20732
Updates tailscale/corp#30042