ACL testing #425
Draft
ACL testing #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ACL testing support to ACL editor for the stil to be reviewed and merged change on headscale side (juanfont/headscale#3005)
I know the guidelines require to link this to feature request but it did not make any sense to create it already for a feature not yet available in upstream headscale. In any case, I am putting this out here so people could do some testing and perhaps it enables things to move forward a bit faster.
It adds detailed status on the bottom and in-editor highlighting of each passed and failed test.
On save if server rejects ACL because of test failures, it runs test action automatically for user to see.
Also it adds syntax error highlighting if server rejects ACL because of syntax error.