Apply transforms correctly #230
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The first commit was merged as part of the original PR that proposed it. Can you explain what problem the second commit solves, and maybe even add a test? |
Author
|
schemars defines transformations to apply to the schema, for eg. compatibility with OpenAPI. These transforms are defined in the schema settings. When aide accesses sub-schemas via |
|
Any news on version bump? |
Collaborator
|
No, sorry. |
Collaborator
|
@Diggsey sorry for the slow feedback. Could you rebase, and add a test for the transforms change? |
jplatte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.