-
Notifications
You must be signed in to change notification settings - Fork 17
Add functionality test based on microceph #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@taodd Can you rebase this with main? That should make the tests pass. I'll then test & review. |
pponnuvel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
But there's a minor issue: the "ceph" cmd can be accessed directly as "microceph" cmd has its own flags & options. So need to replace all "ceph" cmds with "microceph.ceph".
because of this, the test is failing right now.
I also wonder if we need to do all the cleanups and whether we need to check if microceph already exists. Because each time, this is run, a new Ubuntu instance will be created and it won't have microceph.
Cleanups: while it's generally good to cleanup, but in this case, the whole Ubuntu instance will be wiped off regardless of test result. Also if any of the cleanup ops fail, it'll mark the test failed.
| TIMEOUT=120 | ||
| ELAPSED=0 | ||
| while [ $ELAPSED -lt $TIMEOUT ]; do | ||
| if ceph status | grep -q "HEALTH_OK\|HEALTH_WARN"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ceph/microceph.ceph
| ELAPSED=$((ELAPSED + 5)) | ||
| done | ||
|
|
||
| ceph status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ceph/microceph.ceph
|
|
||
| echo "=== Step 8: Create RBD pool and image for testing ===" | ||
| # Create RBD pool if it doesn't exist | ||
| if ! ceph osd pool ls | grep -q "^test_pool$"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/ceph/microceph.ceph
and below too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Pon, let me try to uninstall the pre-installed ceph package and see if it works
|
It's still failing the same way: It suggests there's still the wrong "ceph" command. Perhaps the ceph packages you remove aren't comprehensive? Maybe ceph-common and other exist? I think it'd straightforward to just use |
No description provided.