datetime: supported parse of h's or m's frac part #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 4, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored for better error detection & to simplify code: - offset value post condition check is moved to `parse_tz_suffix`. - this check uses tzoffset valid range instead of int16_t min/max. - offset arg type of `parse_tz_suffix` to valid for TZoffset int16_t. - The better error detection lead to assertion fails of datetime tests with decimal fraction of hours and minutes. So we need tarantool/c-dt#3. It's the first way to fix the problem which is mentioned in tarantool#12082. - datetime.c unit tests refactored. The number of tap test checks is being calculated using the lenght of test data tables. FIXME: need to update c-dt submodule hash. Requires tarantool/c-dt#3 Closes tarantool#12082 NO_DOC=FIXME, must have NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 4, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
- datetime.c unit tests refactored. The number of tap test checks
is being calculated using the lenght of test data tables.
FIXME: need to update c-dt submodule hash.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 10, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
- datetime.c unit tests refactored to simpilfy it's support.
The number of tap test checks is being calculated
using the lenght of test data tables.
FIXME: need to update c-dt submodule hash.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 10, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
- datetime.c unit tests refactored to simpilfy it's support.
The number of tap test checks is being calculated
using the lenght of test data tables.
FIXME: need to update c-dt submodule hash.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 10, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
FIXME: need to update c-dt submodule hash.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
force-pushed
the
i12082
branch
2 times, most recently
from
4a3058f to
91c68e5
Compare
ligurio
reviewed
Dec 12, 2025
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 16, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
FIXME: need to update c-dt submodule hash.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 16, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
FIXME: need to update c-dt submodule hash.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 16, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
FIXME: need to update c-dt submodule hash.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 16, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
FIXME: need to update c-dt submodule hash.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 16, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
FIXME: need to update c-dt submodule hash.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 16, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset int16_t.
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
FIXME: UPDATE c-dt submodule hash TO COMMIT FROM tarantool/c-dt
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=FIXME, must have
NO_CHANGELOG=FIXME, must have
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 16, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset (int16_t).
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=bugfix
FIXME: UPDATE c-dt submodule hash TO COMMIT FROM tarantool/c-dt
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 16, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset (int16_t).
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=bugfix
FIXME: UPDATE c-dt submodule hash TO COMMIT FROM tarantool/c-dt
tmr-g
added a commit
to tmr-g/tarantool
that referenced
this pull request
Dec 16, 2025
- `datetime.c` `parse_tz_suffix` & it's clients refactored
for better error detection & to simplify code:
- offset value post condition check is moved to `parse_tz_suffix`.
- this check uses tzoffset valid range instead of int16_t min/max.
- offset arg type of `parse_tz_suffix` fixed
to valid for TZoffset (int16_t).
- The better error detection lead to assertion fails of datetime tests
with decimal fraction of hours and minutes. So we need
tarantool/c-dt#3. It's the first way to fix the problem which
is mentioned in tarantool#12082.
Requires tarantool/c-dt#3
Closes tarantool#12082
NO_DOC=bugfix
FIXME: UPDATE c-dt submodule hash TO COMMIT FROM tarantool/c-dt
ligurio
reviewed
Dec 25, 2025
Member
ligurio
left a comment
ligurio
left a comment
There was a problem hiding this comment.
Thanks for the patch! Please see my comments.
dt_parse_iso.c
Outdated
Comment on lines
108
to
116
| * hh | ||
| * hh.fffffffff | ||
| * hh,fffffffff | ||
| * hhmm | ||
| * hhmm.fffffffff | ||
| * hhmm,fffffffff | ||
| * hhmmss | ||
| * hhmmss.fffffffff | ||
| * hhmmss,fffffffff |
Member
There was a problem hiding this comment.
please leave a comment with link to ISO 8601-1:2019, 5.3.1.4 where fractional part is described
dt_parse_iso.c
Outdated
| * hh,fffffffff | ||
| * hh:mm | ||
| * hh:mm.fffffffff | ||
| * hh:mm,fffffffff |
Member
There was a problem hiding this comment.
The same as above: please leave a comment with link to standard
t/parse_iso_time.c
Outdated
Comment on lines
126
to
147
| { 1800, 0, "T00.5", 5 }, | ||
| { 450, 0, "T00.125", 7 }, | ||
| { 1199, 0, "T00.333333333", 13 }, | ||
| { 1800, 0, "T00,5", 5 }, | ||
| { 450, 0, "T00,125", 7 }, | ||
| { 1199, 0, "T00,333333333", 13 }, | ||
| { 30, 0, "T00:00.5", 8 }, | ||
| { 15, 0, "T00:00.25", 9 }, | ||
| { 7, 0, "T00:00.125", 10 }, | ||
| { 19, 0, "T00:00.333333333", 16 }, | ||
| { 30, 0, "T00:00,5", 8 }, | ||
| { 15, 0, "T00:00,25", 9 }, | ||
| { 7, 0, "T00:00,125", 10 }, | ||
| { 19, 0, "T00:00,333333333", 16 }, | ||
| { 30, 0, "T0000.5", 7 }, | ||
| { 15, 0, "T0000.25", 8 }, | ||
| { 7, 0, "T0000.125", 9 }, | ||
| { 19, 0, "T0000.333333333", 15 }, | ||
| { 30, 0, "T0000,5", 7 }, | ||
| { 15, 0, "T0000,25", 8 }, | ||
| { 7, 0, "T0000,125", 9 }, | ||
| { 19, 0, "T0000,333333333", 15 }, |
Member
There was a problem hiding this comment.
I don't get how you chose a number for a fractional part.
I would check max (999999999), min (000000000) and average (any number in (0, 999999999)), and your choice: 5, 24, 125 and 333333333.
t/parse_iso_time.c
Outdated
Comment on lines
126
to
131
| { 1800, 0, "T00.5", 5 }, | ||
| { 450, 0, "T00.125", 7 }, | ||
| { 1199, 0, "T00.333333333", 13 }, | ||
| { 1800, 0, "T00,5", 5 }, | ||
| { 450, 0, "T00,125", 7 }, | ||
| { 1199, 0, "T00,333333333", 13 }, |
Member
There was a problem hiding this comment.
for unknown reasons .25 is missed for both formats
| @@ -24,6 +24,7 @@ | |||
| * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
Member
There was a problem hiding this comment.
please link to standard (ISO 8601-1:2019, 5.3.1.4) in the commit message
t/parse_iso_time.c
Outdated
| { 1800, 0, "T00,5", 5 }, | ||
| { 450, 0, "T00,125", 7 }, | ||
| { 1199, 0, "T00,333333333", 13 }, | ||
| { 30, 0, "T00:00.5", 8 }, |
Member
There was a problem hiding this comment.
should these tests fail?
--- a/t/parse_iso_time.c
+++ b/t/parse_iso_time.c
@@ -125,10 +125,10 @@ const struct good_t {
{ 0, 0, "T000000.000000000", 17 },
{ 1800, 0, "T00.5", 5 },
{ 450, 0, "T00.125", 7 },
- { 1199, 0, "T00.333333333", 13 },
+ { 1199, 0, "T00.3333333331", 14 },
{ 1800, 0, "T00,5", 5 },
{ 450, 0, "T00,125", 7 },
- { 1199, 0, "T00,333333333", 13 },
+ { 1199, 0, "T00,3333333331", 14 },
{ 30, 0, "T00:00.5", 8 },
{ 15, 0, "T00:00.25", 9 },
{ 7, 0, "T00:00.125", 10 },now tests passed
Author
There was a problem hiding this comment.
More than 9 fraction digits is truncated. Comments added.
Here is the case with 10 digits (line 60):
Lines 58 to 60 in edeaa5f
Similar tests added.
hh.hh & hhmm.mm parsing in dt_iso_parse.c implemented. Such formats are defined in ISO 8601-1:2019 (5.3.1.4). They are used in tarantool datetime tests. Need for tarantool/tarantool#12082 tarantool/tarantool#12083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hh.hh & hhmm.mm parsing in dt_iso_parse.c implemented.
Such formats are defined in ISO 8601-1:2019 (5.3.1.4).
They are used in tarantool datetime tests.
Need for tarantool/tarantool#12082 tarantool/tarantool#12083