Merged
Conversation
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-1918-bump-ubuntu-version
branch
6 times, most recently
from
c4cdc3c to
a28fb18
Compare
oleg-jukovec
approved these changes
Apr 9, 2025
.github/workflows/testing.yaml
Outdated
Comment on lines
54
to
58
| # https://github.com/tarantool/memcached/issues/115 | ||
| # - run: make test-memcached-capable | ||
|
|
||
| - name: Run benchmarks | ||
| run: make test-memcached-bench | ||
| # https://github.com/tarantool/memcached/issues/90 | ||
| # - name: Run benchmarks | ||
| # run: make test-memcached-bench |
Contributor
Author
There was a problem hiding this comment.
Cause it doesn't work by the same reason as test-memcached-capable.
elhimov
reviewed
Apr 10, 2025
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-1918-bump-ubuntu-version
branch
3 times, most recently
from
a31ba0a to
3487ce4
Compare
patapenka-alexey
requested review from
elhimov and
oleg-jukovec
and removed request for
oleg-jukovec
oleg-jukovec
approved these changes
Apr 17, 2025
elhimov
approved these changes
Apr 17, 2025
elhimov
left a comment
elhimov
left a comment
There was a problem hiding this comment.
LGTM, but consider using -y option with apt install
Bump actions to use ubuntu-24.04 for fixing the following GitHub
warning:
The Ubuntu 20.04 Actions runner image will begin deprecation
on 2025-02-01.
This commit adds CMake policy to prevent warnings from
old third_party dependencies, bumps libmemcached third_party library
to support build on Ubuntu 24.04.
Part of #TNTP-1918
Closes #115
patapenka-alexey
force-pushed
the
patapenka-alexey/tntp-1918-bump-ubuntu-version
branch
from
3487ce4 to
bc36ccf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump actions to use ubuntu-24.04 for fixing the following GitHub
warning:
This commit adds CMake policy to prevent warnings from
old third_party dependencies, bumps libmemcached third_party library
to support build on Ubuntu 24.04.
Part of #TNTP-1918
Closes #115