replicaset: do not close initial conn during retryable error #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch the logic of discarding and nullification of vconnect's future object was located only in `netbox_on_disconnect` trigger. As in next patches we need to add this logic in other places, we introduce a new replicaset function - `conn_vconnect_reset`. Needed for tarantool#632 NO_TEST=refactoring NO_DOC=refactoring
mrForza
force-pushed
the
mrforza/gh-632-connection-is-closed-during-init-connection
branch
2 times, most recently
from
38f481a to
445e990
Compare
Before this patch the replicaset closed an initial netbox connection during name check (`vconnect` stage) when retryable error happened on the storage side (`STORAGE_IS_DISABLED`, `NO_SUCH_PROC`, `AccessDeniedError`). It was happening because `conn_vconnect_check_or_close` and `conn_vconnect_wait_or_close` functions didn't have the logic with retryable errors. This bug led to alerts on the router and as a result to problems in high-level products which worked using vshard (e.g. TDG). To fix this bug we introduce new replicaset helper functions - `conn_vconnect_is_retryable_error` and `conn_vconnect_try_to_restart`. They can help us to determine whether the error is retryable and restart vconnect. We use it in `conn_vconnect_check_or_close` and `conn_vconnect_wait_or_close`. Also we delete one vconnect test - `test_vconnect_no_result` because it tests the behavior which is changed by our new patch. Closes tarantool#632 NO_DOC=bugfix
mrForza
force-pushed
the
mrforza/gh-632-connection-is-closed-during-init-connection
branch
from
445e990 to
e9f3a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch the replicaset closed an initial netbox connection
during name check (
vconnectstage) when retryable error happened on thestorage side (
STORAGE_IS_DISABLED,NO_SUCH_PROC,AccessDeniedError).It was happening because
conn_vconnect_check_or_closeandconn_vconnect_wait_or_closefunctions didn't have the logic withretryable errors. This bug led to alerts on the router and as a result to
problems in high-level products which worked using vshard (e.g. TDG).
To fix this bug we introduce new replicaset helper functions -
conn_vconnect_is_retryable_errorandconn_vconnect_try_to_restart.They can help us to determine whether the error is retryable and restart
vconnect. We use it in
conn_vconnect_check_or_closeandconn_vconnect_wait_or_close.Also we delete one vconnect test -
test_vconnect_no_resultbecause ittests the behavior which is changed by our new patch.
Closes #632
NO_DOC=bugfix