Merged
Conversation
To support monorepos on windows, where protoscript might not actually be located in the project root's own node_modules, but in the monorepo's node_modules, use %~p0 to find compiler.js relative to the cmd file instead of relative to the current working directory
Owner
|
Hey @lordvlad thanks for the PR. I’d totally overlooked that this was still hardcoded 🤦♂️ I think the most robust way to handle this is updating to using npm exec or a require and execute one liner so we can rely on nodes resolution for this. What do you think? |
Contributor
Author
|
Worked nicely for me. Not sure we need a more elaborate way, might make it
more fragile
…On Fri, Feb 7, 2025 at 2:01 AM Tate Thurston ***@***.***> wrote:
Hey @lordvlad <https://github.com/lordvlad> thanks for the PR. I’d
totally overlooked that this was still hardcoded 🤦♂️
I think the most robust way to handle this is updating to using npm exec
or a require and execute one liner so we can rely on nodes resolution for
this.
What do you think?
—
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJJJ2JI6XFRDCDR2VS3H232OQAVFAVCNFSM6AAAAABWPTGLB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBRGU3DENBZGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
tatethurston
pushed a commit
that referenced
this pull request
Feb 23, 2025
To support monorepos on windows, where protoscript might not actually be located in the project root's own node_modules, but in the monorepo's node_modules, use %~p0 to find compiler.js relative to the cmd file instead of relative to the current working directory
tatethurston
pushed a commit
that referenced
this pull request
Feb 23, 2025
To support monorepos on windows, where protoscript might not actually be located in the project root's own node_modules, but in the monorepo's node_modules, use %~p0 to find compiler.js relative to the cmd file instead of relative to the current working directory
tatethurston
added a commit
that referenced
this pull request
Feb 23, 2025
To support monorepos on windows, where protoscript might not actually be located in the project root's own node_modules, but in the monorepo's node_modules, use %~p0 to find compiler.js relative to the cmd file instead of relative to the current working directory Co-authored-by: Waldemar Reusch <lordvlad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support monorepos on windows, where protoscript might not actually be located in the project root's own node_modules, but in the monorepo's node_modules, use %~p0 to find compiler.js relative to the cmd file instead of relative to the current working directory