Correctly parse table with first cell of a row being empty #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxyzz
force-pushed
the
empty-first-table-cell
branch
from
66f170a to
44d1268
Compare
Collaborator
|
I add some changes to fix some tests in wiktextract. |
kristian-clausal
approved these changes
Nov 20, 2025
Collaborator
kristian-clausal
left a comment
kristian-clausal
left a comment
There was a problem hiding this comment.
This seems good, thanks for catching this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table syntax allows separating cells using either a single
|at the beginning of the line or||elsewhere. If the first cell is completely empty, this results in|||, which wikitextprocessor currently parses like||followed by|instead. This leads to incorrect results for example with the conjugation table for 돌아가시다 on English Wiktionary.This PR fixes this by giving the single
|token higher precedence if it occurs at the beginning of a line.