Skip to content

(feat) change getVideo to getJSXVideo #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azai91 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(feat) change getVideo to getJSXVideo #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions build/react-ice.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions examples/chatroom/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ var Chatroom = React.createClass({
var localVideo;
var remoteVideos = [];
if (this.state.icecomm.local) {
localVideo = this.state.icecomm.local.getVideo();
localVideo = this.state.icecomm.local.getJSXVideo();
}
if (this.state.icecomm.peers) {
for (var i = 0; i < this.state.icecomm.peers.length; i++) {
remoteVideos.push(this.state.icecomm.peers[i].getVideo());
remoteVideos.push(this.state.icecomm.peers[i].getJSXVideo());
}
}
return (
Expand Down
8 changes: 4 additions & 4 deletions src/react-ice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ function updateInitialState() {
function updateIcecommState(icecommState, event, value) {
if (event === 'connected') {
icecommState.peers = icecommState.peers || [];
value = addGetVideo(value);
value = addGetJSXVideo(value);
icecommState.peers.push(value);
}
if (event === 'local') {
value = addGetVideo(value);
value = addGetJSXVideo(value);
icecommState.local = value;
}
if (event === 'disconnect' && icecommState.peers) {
Expand All @@ -61,8 +61,8 @@ function updateIcecommState(icecommState, event, value) {
return icecommState;
}

function addGetVideo(peer) {
peer.getVideo = function() {
function addGetJSXVideo(peer) {
peer.getJSXVideo = function() {
return (<video src={peer.stream} autoPlay muted></video>);
}
return peer;
Expand Down