enh: UI Updates & Improvements #6
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates Netshow's UI from the Selenized Dark theme to Solarized Dark, while adding responsive design capabilities and real-time network monitoring features. The changes focus on improving visual clarity through color-coded status indicators and adapting the interface to different terminal widths.
Key Changes:
- Complete theme migration from Selenized to Solarized Dark color palette with color-coded metric borders
- Added responsive layout that adjusts labels and visibility based on terminal width (compact mode < 100 columns)
- Introduced bandwidth sparkline visualization with 20-sample history and IPv6 address truncation toggle
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/netshow/types_and_constants.py | Added "v" keybinding for IPv6 address expansion toggle |
| src/netshow/styles.py | Replaced Selenized Dark theme with Solarized Dark palette, added sparkline styling and responsive metric borders |
| src/netshow/helpers.py | Reformatted address formatting logic for improved readability |
| src/netshow/detail_screen.py | Code formatting improvements for conditional expressions |
| src/netshow/cli.py | Added truecolor environment variable detection for optimal theme rendering |
| src/netshow/app.py | Implemented bandwidth sparkline, IPv6 truncation, responsive metrics, Rich Text status styling, and terminal resize handling |
| pyproject.toml | Updated Textual dependency from >=0.40.0 to >=3.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Rich Text object - extract plain text and remove emoji prefix | ||
| status_text = status_cell.plain | ||
| # Remove emoji prefix if present (emoji + space = ~3 chars) |
There was a problem hiding this comment.
The comment states 'emoji + space = ~3 chars' but the code uses split(' ', 1)[-1] which only splits on a single space character. Emojis can be 1-4 bytes in UTF-8, but the code doesn't account for character length. The comment should be updated to accurately describe the string splitting operation being performed.
| # Rich Text object - extract plain text and remove emoji prefix | |
| status_text = status_cell.plain | |
| # Remove emoji prefix if present (emoji + space = ~3 chars) | |
| # Rich Text object - extract plain text and remove emoji/icon prefix | |
| status_text = status_cell.plain | |
| # Remove leading emoji/icon prefix and following space by taking text after the first space |
This PR introduces a major UI overhaul for Netshow using Solarized Dark theme, adaptive responsive design, and enhanced network monitoring capabilities including real-time bandwidth visualization.
Key Improvements
• Solarized Dark Theme: Complete visual redesign with color-coded status indicators
• Responsive Design: Adaptive layout that adjusts to terminal width (compact mode for narrow terminals)
• Real-time Bandwidth Sparkline: Visual graph showing network activity trends over time
• IPv6 Address Management: Auto truncation with toggle option (v key) for full expansion
• Performance Optimizations: Streamlined code formatting and improved rendering efficiency
• Enhanced Status Display: Rich text styling with Solarized color coding for connection states
Technical Changes
Theme & Styling (src/netshow/styles.py)
Core Application (src/netshow/app.py)
CLI Enhancement (src/netshow/cli.py)
New Features
UI/UX Improvements
Dependencies