Get path as created #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Must pass cssProps to all elements utilizing transition-move.
turn 1, 9/11/19 through turn 17 9/27/2019
generalized method
troubling. I want filtered and show to be seperate states. but x is calculated on show. i could make a displayed state and a show state. Then filtering just overrides displayed(setDisplayed) if its not empty?
Beware when +&- child are desplayed, but not parent. they collapse and with nothing between them, they overlap... Not much I can do atm. maybe something like: const test = Math.abs(xConst[xConst.length-1])===1&&xConst.length>1&&!_.isEmpty(state.filtered)?Math.sign(xConst[xConst.length-1]):0 return sum+test idk...
If zero is not present in search results, pseudoZero will add the appropriate displacement based on the sign of branch under calculation. Additionally, if search result length is 1, then pseudoZero will not be calculated. Fixed isActive flase-positive during search. It is now disabled.
Disable Transition On Scaling
Plot by Date
…item Extend/Replace D-string items
Search Branches
v-model on page updates values. watcher tracks changes and triggers updates. updateCache() calculates new values.
I wanted to add the necessary data to this file to keep it localized and easier to access. However, mixins are not meant share data, just funtionality like methods. As a result they are not terribly reactive. The two solution I wish to try are making it a global mixin and adding it back to vuex perhaps as a module.
moving the slider explodes the console with hundres of nonsense function calls...
Still lots to figure out as it revives mixin/Vuex hybrid. Will pursue both pure Vuex and hybrid.
again this is probably bad form, mixins shouldnt be used to share data. But just wanted to try.
I have moved most dependancies to vuex. I have had to add updateCache to multiple locations: CollapseState.vue(onChg), Paths.vue(toggleChildren), Search.vue(filteredList), VGitGraph(created) now pass coords attribute to VGitGraph sub-component Paths.vue gets dispCoords from cache. Next: - remove DisplayMixin.js, maybe make coordinate module - maybe try $store.watch again to remove update cache from everywhere and help centralize code.
some clean up too
This reverts commit 7163b15.
Computed may be better if it needs to be updated when new content is added though... ?
"Computed properties are cached based on their reactive dependencies. A computed property will only re-evaluate when some of its reactive dependencies have changed." – from the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.