-
Notifications
You must be signed in to change notification settings - Fork 5
Add plan mode detection pattern for Claude Code #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add patterns to detect Claude Code's "Enter plan mode?" prompt so the extension can properly transition to 'waiting' status. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @eatnug, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the extension's ability to accurately monitor and reflect the state of Claude Code. By introducing specific detection patterns for Claude Code's 'plan mode' prompts, the extension can now correctly identify when this mode is active and update its status accordingly, leading to a more responsive and intuitive user experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds detection patterns for Claude Code's plan mode, which is a useful enhancement. The new regular expressions appear correct for identifying the plan mode prompt and menu option. My main feedback is to recommend adding unit tests for these new patterns to ensure they are covered and to prevent future regressions. This will improve the overall quality and maintainability of the code.
| /Enter plan mode\?/i, // Plan mode prompt | ||
| /Yes,\s*enter plan mode/i, // Plan mode menu option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new patterns for detecting plan mode are a good addition. To ensure they work as expected and prevent future regressions, please add corresponding unit tests in src/test/domain/services/TerminalStatusDetector.test.ts.
For example:
test('detects waiting status from plan mode prompt', () => {
const output = 'Enter plan mode?';
const status = detector.detect('claude', output);
assert.strictEqual(status, 'waiting');
});
test('detects waiting status from plan mode menu option', () => {
const output = '1. Yes, enter plan mode';
const status = detector.detect('claude', output);
assert.strictEqual(status, 'waiting');
});
Summary
Test plan
🤖 Generated with Claude Code