Skip to content

Task #149584 chore: Resolve - Display notice if subuserId is not present #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shraddhaSankpal27 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Task #149584 chore: Resolve - Display notice if subuserId is not present #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion administrator/models/hierarchys.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ public function getItems()
$item->ReportsToUserName = array();
$item->ReportsTo = array();

if ($item->subuserId)
if (isset($item->subuserId))
Copy link

@vaivk369 vaivk369 Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only isset will work? what if it is set to blank?

{
$results = $this->hierarchyModel->getReportsTo($item->user_id);
$item->ReportsTo = $results;
Expand Down