Skip to content

Conversation

@technologic-technologic
Copy link
Owner

Updated the expiration date selector while creating or updating a products to avoid using past dates. Added necessary logic to the BS as well. More info below

Updated the expiration date selector while creating or updating a products to avoid using past dates. Added necessary logic to the BS as well.
@github-actions
Copy link

Summary of Pull Request

  • WHAT Changed:

    • Updated GitHub Actions workflows in build.yml and pre-release.yml to remove the working-directory setting.
    • Removed cache-dependency-path from the Node setup in both workflows.
    • Modified the .gitignore file to include package-lock.json.
    • Added @testing-library/user-event dependency to package-lock.json.
    • Enhanced validation logic for the expiration date in ProductForm.tsx to prevent past dates.
  • WHY It Matters:

    • Simplifying the workflows by removing unnecessary settings can improve maintainability and reduce potential errors.
    • Including package-lock.json in .gitignore ensures that it won't be accidentally tracked, which is important for dependency management.
    • The addition of validation logic enhances user experience by preventing invalid input.
  • RISKS:

    • Removing the working-directory may affect builds if the repository structure relies on it.
    • Changes to the validation logic could introduce unexpected behavior if not properly tested.
  • TESTS to Add:

    • Unit tests for the new expiration date validation logic to ensure it correctly handles various date inputs.
    • Integration tests for the workflows to verify that builds and pre-releases function correctly without the removed settings.
  • BREAKING CHANGES:

    • None identified, but the removal of working-directory could lead to issues if the build process relies on it.
  • Changed File Paths:

    • .github/workflows/build.yml
    • .github/workflows/pre-release.yml
    • inventory-manager/.gitignore
    • inventory-manager/package-lock.json
    • inventory-manager/src/components/page-content/segment2-new_product/ProductForm.tsx

@technologic-technologic technologic-technologic merged commit 69cb7dc into stage Oct 17, 2025
1 check passed
@technologic-technologic technologic-technologic deleted the 53-fix-expiration-datepicker branch October 17, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid past dates in the expiration date DatePicker

2 participants