Improve SQLite and map performance#63
Open
BryceStevenWilley wants to merge 2 commits intotechnosophos:masterfrom
Open
Improve SQLite and map performance#63BryceStevenWilley wants to merge 2 commits intotechnosophos:masterfrom
BryceStevenWilley wants to merge 2 commits intotechnosophos:masterfrom
Conversation
With profiling, was able to improve two points of performance: * use SQLite transactions to greatly speedup inserts * looking into the entities map. For most characters, we don't need to check the map, so added a quick comparison operator to improve that On my general workload + machine, this improves things from taking 35 seconds to things take 2 seconds. Most of the timesave was from the SQLite improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if significant performance improvements are considered under maintenance. If not, feel free to close.
Inspired by #59, with profiling, was able to improve two points of performance:
On my general workload (generating a docset with 348 entities) on my machine, this improves
things from taking 35 seconds to things take 2 seconds. Most of the timesave was from the SQLite improvements.
Realizing that most of the changed lines here were organizing the entities map, which didn't make a difference except for in making the smallest rune clearer. Happy to revert that if desired.