Skip to content

Use "id" of elements for anchors instead of auto-generating a tag #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antifuchs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use "id" of elements for anchors instead of auto-generating a tag #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions dashing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,14 +628,27 @@ func attr(node *html.Node, key string) string {
// NOTE: NOT THREADSAFE. If we switch to goroutines, swith to atom int.
var tcounter int

func anchor(node *html.Node) string {
if node.Type == html.ElementNode && node.Data == "a" {
for _, a := range node.Attr {
if a.Key == "name" {
return a.Val
}
// nodeAttrValue returns the value for a node attribute, and a flag
// indicating whether that node has the attribute.
func nodeAttrValue(node *html.Node, attrName string) (string, bool) {
if node.Type != html.ElementNode {
return "", false
}
for _, a := range node.Attr {
if a.Key == attrName {
return a.Val, true
}
}
return "", false
}

func anchor(node *html.Node) string {
if idVal, ok := nodeAttrValue(node, "id"); ok {
return idVal
}
if nameVal, ok := nodeAttrValue(node, "name"); ok && node.Data == "a" {
return nameVal
}
tname := fmt.Sprintf("autolink-%d", tcounter)
link := autolink(tname)
node.Parent.InsertBefore(link, node)
Expand Down