Fix PS2_KEY_PAUSE value (my attempt without having v1.0.10)#37
Open
ludolpif wants to merge 2 commits intotechpaul:masterfrom
Open
Fix PS2_KEY_PAUSE value (my attempt without having v1.0.10)#37ludolpif wants to merge 2 commits intotechpaul:masterfrom
ludolpif wants to merge 2 commits intotechpaul:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Here my attempt to fix PS2_KEY_PAUSE returned value (was : 0x6 instead of 0x5) to address issues #35, #26, #5.
I checked that, in translate(), variable data equals to 0x77 when processing the Pause/break key special case, so it seems that there is no side effect of move the code section near the if ( ... & _E1_MODE ) case, that is after the
if( ( data >= PS2_KC_BAT && data != PS2_KC_LANG1 && data != PS2_KC_LANG2 )
check.