Make the application installable in Linux File Hierarchy Standard#24
Draft
ekohl wants to merge 6 commits intoteddych:masterfrom
Draft
Make the application installable in Linux File Hierarchy Standard#24ekohl wants to merge 6 commits intoteddych:masterfrom
ekohl wants to merge 6 commits intoteddych:masterfrom
Conversation
Merged
Contributor
Author
|
I wrote this before 6a93548 was merged so this doesn't write the docs to |
Owner
|
I have three change requests:
|
6548167 to
fed367a
Compare
Contributor
Author
|
I haven't made changes on what I think is still needed to implement this, but does this address your code style concerns? |
Owner
|
You understood what I wanted to say. |
ekohl
commented
Jan 13, 2026
Comment on lines
60
to
66
| if (env_p) | ||
| std::filesystem::path dir(env_p); | ||
| else | ||
| std::filesystem::path dir("."); |
Contributor
Author
There was a problem hiding this comment.
Note to self when I continue:
Suggested change
| if (env_p) | |
| std::filesystem::path dir(env_p); | |
| else | |
| std::filesystem::path dir("."); | |
| if (env_p) | |
| { | |
| std::filesystem::path dir(env_p); | |
| } | |
| else | |
| { | |
| std::filesystem::path dir("."); | |
| } |
This creates Utils::Paths that holds the definitions for where data is stored. This can differ per OS and makes it easy to change.
C++20 has deprecated the ++ and -- operations on volatile and C++26 is looking at removing them. This replaces them with an explicit update.
fed367a to
38027c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a work in progress, but a step for #19: I want to install the binary to
/usr/binand data files to/usr/share/railcontrol, while still maintaining support for the "all in the same directory"-build.To do so I've introduced an abstraction layer. After doing so I also noticed it creates log files, but with systemd logging to stdout is probably better anyway so in the service I'll likely disable that altogether.
The abstraction layer uses
std::filesystemwhich is introduced in C++17 so I also updated the codebase to be compiled with it, but didn't go back to all code to use it.