Replace volatile stopSignalCounter ++ operator

[ekohl]

C++20 has deprecated the ++ and -- operations on volatile and C++26 is looking at removing them. This replaces them with an explicit update.

Fixes #30

[teddych]

Logger.h is not used in Railcontrol.h.
It is used in Railcontrol.cpp and there it is explicitly invoked.

[ekohl]

Logger.h is not used in Railcontrol.h.

When I edited Railcontrol.h my editor complained about missing it because Logger::Logger wasn't defined but is used here:
https://github.com/teddych/railcontrol/blob/a50cf8f0653613ea5509477fabd4425b07c8dead/RailControl.h#L27C30-L27C44

That went away when I included Logger.h.

[teddych]

The information of Logger.h or the content of class Logger is not need to compile. But to prevent a warning I expect that

namespace
{
class Logger;
}

will prevent the warning without including the complete header file.

[ekohl]

I can take the commit out of the PR since I think technically it isn't required to fix the issue I was after. I only included it because it's changing the same file and it would be a conflict later.

[teddych]

Another word to volatile or atomic:
Here I need really a volatile variable. But it is not important if it is atomic. The ++ operator is not atomic, but it is intended to be atomic by a lot of programmers (that never worked on embedded systems). Because the intention is wrong it is removed completely.

What I really need in the code is:

stopSignalCounter = stopSignalCounter + 1;
if (stopSignalCounter < MaxStopSignalCounter)

So if you want to change, then do not remove/replace the volatile but remove the ++ operator, please.

[ekohl]

Note I don't know for sure if this is correct so please verify it carefully.

And that's exactly what you did. Thanks!

[ekohl]

I pushed an update, but I don't have an env where I can reproduce the failure at hand now so keeping it as draft.

[teddych]

It is in state Draft. Therefore I can't merge. Can you change it?

[ekohl]

I just tested this in my tentative Fedora packaging build where I noticed it for the first time and I can see it now compiles.