Install documentation to destination dir#36
Open
ekohl wants to merge 6 commits intoteddych:masterfrom
Open
Conversation
Owner
|
Fuddl already change plenty of CMakeLists.txt across the documentation so this can't be merged... |
Contributor
|
My apologies, I didn't notice @ekohl was working on this. I highly appreciate when someone improves my messy cmake configuration. |
Contributor
Author
This makes it clearer how items are related.
Instead of using a custom command, this uses the built in functionality.
It's up for debate whether this is better or worse. It is fewer lines of
code, but it's also easy to miss when a file is added/removed.
It doesn't do the same for DOC_{DE,EN,ES} because I'm unsure if it
affects the resulting build.
ekohl
force-pushed
the
simplify-docs-building-v2
branch
from
9d2c86a to
8f2578a
Compare
Contributor
I lack cmake experience to judge that well-founded. My 2 cents: I favour the easy to understand solution over a technical sophisticated one in this case. Hope that helps :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My goal is to install the documentation natively and I think this is cleaner. I've tried to separate it into individual commits so it's easier to follow (hence the v2 in my branch name).
Another approach I considered was to create
Documentation/CMakeLists.txtto separate it, allowing you to build documentation from that directory. Let me know if that is a preferred approach and I can dig up the branch where I experimented with that.