[cherry-pick:release-v0.78.x] Remove default Artifacthub url override #3121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch includes the following changes: - Remove the default Hub catalog configuration from the PAC settings before PAC SyncConfig function call as this is already handled by the PAC SyncConfig function - Remove the default ArtifactHub URL override, which is managed by PAC. - Update the transform test to align with PAC changes, hub_url should not be fetchable, and PAC will now set the catalog type to tektonhub. Signed-off-by: Shiv Verma <shverma@redhat.com>
Signed-off-by: Shiv Verma <shverma@redhat.com>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
Contributor
|
/retest |
Contributor
|
/kind bug |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anithapriyanatarajan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Contributor
|
/lgtm |
tekton-robot
merged commit 40e029b
into
tektoncd:release-v0.78.x
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cherry-pick of #3091
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes