fix: Prevent CI job skips on PRs with large file counts #3150
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolve false negatives when detecting non-doc changes in 1000+ file PRs - Avoid bash variable size limits by piping git diff directly to grep - Ensure vendor updates trigger required builds and tests Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
Contributor
|
@aThorp96: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
/approve |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aThorp96, jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vdemeester
added a commit
that referenced
this pull request
Jan 13, 2026
The categorize changes job was failing with exit code 141 (SIGPIPE). This occurred because with pipefail enabled, when git diff pipes to commands like head or grep that exit early, git diff receives SIGPIPE and the entire pipeline fails with exit code 141. The issue manifests in two places: 1. `git diff | head -50` - head exits after 50 lines 2. `git diff | grep > /dev/null` - grep exits after finding matches With pipefail, these SIGPIPE failures cause the whole script to fail. Solution: Temporarily disable pipefail for the detection logic since we only care about the exit status of head/grep, not the pipe status. This completes the fix for the SIGPIPE issues identified in PRs #3150 and #3152, which addressed variable size limits and grep -q issues. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Member
|
/cherry-pick release-v0.71.x |
Contributor
|
❌ Cherry-pick to The automatic cherry-pick to Output: Next steps:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes CI job detection failure on PRs with large file counts (1000+ files).
Problem
PRs like #3146 and #2914 with vendor updates (2000+ changed files) had their CI builds incorrectly skipped. The detection logic stored all filenames in a bash variable which exceeded size limits, causing grep to fail and falsely report
non-docs=false.Solution
.github/workflows/ci.yamlto pipe git diff directly to grep instead of storing output in variablesTesting
Verified locally with PR #3146 data (2243 files):
non-docs=false❌non-docs=true✅Submitter Checklist
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes